Skip to content

fix(lightspeed): update missing permission illsutration#3261

Merged
its-mitesh-kumar merged 3 commits into
redhat-developer:mainfrom
rohitratannagar:fix/lightspeed-missing-permission-image
Jun 4, 2026
Merged

fix(lightspeed): update missing permission illsutration#3261
its-mitesh-kumar merged 3 commits into
redhat-developer:mainfrom
rohitratannagar:fix/lightspeed-missing-permission-image

Conversation

@rohitratannagar
Copy link
Copy Markdown
Contributor

@rohitratannagar rohitratannagar commented Jun 1, 2026 •
edited
Loading

Summary

Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3152

  • Replaced the old permission-required SVG with the new illustration
  • Refactored PermissionRequiredState to reuse Backstage's <EmptyState/> component from @backstage/core-components, aligning with the pattern used in adoption-insights
  • Retained responsive behavior via CSS container queries on the wrapper:
    • In overlay/docked mode (narrow): centered stacked layout with image above text
    • In fullscreen/embedded mode (wide): side-by-side layout with text on left, image on right
  • Image and text sizes scale fluidly with available space using clamp() and cqi units

UI after changes

Screen.Recording.2026-06-02.at.1.02.02.AM.mov

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

@rohitratannagar
fix(lightspeed): update missing permission illsutration
8ffd654 
Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app Bot commented Jun 1, 2026 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
app-legacy workspaces/lightspeed/packages/app-legacy none v0.0.27
app workspaces/lightspeed/packages/app none v0.0.26
@red-hat-developer-hub/backstage-plugin-lightspeed workspaces/lightspeed/plugins/lightspeed patch v2.9.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.58%. Comparing base (ac69555) to head (24674e4).
⚠️ Report is 17 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
+ Coverage   53.57%   53.58%   +0.01%     
==========================================
  Files        2407     2408       +1     
  Lines       86535    86545      +10     
  Branches    23943    23946       +3     
==========================================
+ Hits        46361    46377      +16     
+ Misses      38692    38686       -6     
  Partials     1482     1482
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 8c823bd
ai-integrations 70.03% <ø> (ø) Carriedforward from 8c823bd
app-defaults 69.60% <ø> (ø) Carriedforward from 8c823bd
augment 46.39% <ø> (ø) Carriedforward from 8c823bd
bulk-import 72.86% <ø> (ø) Carriedforward from 8c823bd
cost-management 16.49% <ø> (ø) Carriedforward from 8c823bd
dcm 45.40% <ø> (ø) Carriedforward from 8c823bd
extensions 61.79% <ø> (ø) Carriedforward from 8c823bd
global-floating-action-button 74.30% <ø> (ø) Carriedforward from 8c823bd
global-header 61.63% <ø> (ø) Carriedforward from 8c823bd
homepage 51.52% <ø> (ø) Carriedforward from 8c823bd
konflux 91.01% <ø> (ø) Carriedforward from 8c823bd
lightspeed 68.50% <ø> (+0.16%) ⬆️
mcp-integrations 85.46% <ø> (ø) Carriedforward from 8c823bd
orchestrator 36.60% <ø> (ø) Carriedforward from 8c823bd
quickstart 62.88% <ø> (ø) Carriedforward from 8c823bd
sandbox 79.56% <ø> (ø) Carriedforward from 8c823bd
scorecard 83.84% <ø> (ø) Carriedforward from 8c823bd
theme 64.54% <ø> (ø) Carriedforward from 8c823bd
translations 8.49% <ø> (ø) Carriedforward from 8c823bd
x2a 78.79% <ø> (ø) Carriedforward from 8c823bd

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac69555...24674e4. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cursoragent
fix(lightspeed): upgrade Playwright to 1.60.0 for Node 24 CI install
8c823bd 
Playwright < 1.60.0 hangs after browser download on Node 24.16+ during
playwright install in GitHub Actions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rohitratannagar
Copy link
Copy Markdown
Contributor Author

rohitratannagar commented Jun 2, 2026

/cc @ShiranHi

@openshift-ci openshift-ci Bot requested a review from ShiranHi June 2, 2026 08:40
@HusneShabbir HusneShabbir mentioned this pull request Jun 2, 2026
Merged
2 tasks
HusneShabbir
HusneShabbir reviewed Jun 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@HusneShabbir HusneShabbir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Tested locally, works as expected

Screen.Recording.2026-06-02.at.4.20.48.PM.mov

@openshift-ci openshift-ci Bot added the lgtm label Jun 2, 2026
@HusneShabbir
Copy link
Copy Markdown
Contributor

HusneShabbir commented Jun 2, 2026 •
edited
Loading

@rohitratannagar, the implementation looks a bit different from the Figma design. I’d recommend waiting until @ShiranHi approves the changes.

@ShiranHi
Copy link
Copy Markdown

ShiranHi commented Jun 2, 2026

Thanks for this, @rohitratannagar , it looks great overall. Just two small adjustments:

  • Docked/Overlay modes: We need to fix the padding between the image and the title
  • TAdjust the formatting for the "Missing permission" text

The rest looks good to go!

@openshift-ci openshift-ci Bot removed the lgtm label Jun 3, 2026
@rohitratannagar
reuse EmptyState component in PermissionRequiredState
24674e4 
Signed-off-by: rohitratannagar <rohitratannagar2003@gmail.com>
@rohitratannagar rohitratannagar force-pushed the fix/lightspeed-missing-permission-image branch from b64239f to 24674e4 Compare June 4, 2026 09:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rohitratannagar
Copy link
Copy Markdown
Contributor Author

rohitratannagar commented Jun 4, 2026

Thanks for this, @rohitratannagar , it looks great overall. Just two small adjustments:

  • Docked/Overlay modes: We need to fix the padding between the image and the title
  • TAdjust the formatting for the "Missing permission" text

The rest looks good to go!

fixed!!

Screen.Recording.2026-06-04.at.4.04.54.PM.mov

its-mitesh-kumar
its-mitesh-kumar reviewed Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitratannagar Can you also provide the screenshots for Notebook Permission page?

@rohitratannagar
Copy link
Copy Markdown
Contributor Author

rohitratannagar commented Jun 4, 2026

@rohitratannagar Can you also provide the screenshots for Notebook Permission page?

Screenshot 2026-06-04 at 4 23 25 PM

its-mitesh-kumar
its-mitesh-kumar approved these changes Jun 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jun 4, 2026
@its-mitesh-kumar its-mitesh-kumar merged commit b5bb972 into redhat-developer:main Jun 4, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HusneShabbir HusneShabbir HusneShabbir left review comments

@its-mitesh-kumar its-mitesh-kumar its-mitesh-kumar approved these changes

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar karthikjeeyar is a code owner

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03 rohitkrai03 is a code owner

@yangcao77 yangcao77 Awaiting requested review from yangcao77 yangcao77 is a code owner

@ShiranHi ShiranHi Awaiting requested review from ShiranHi

Assignees

@HusneShabbir HusneShabbir

@its-mitesh-kumar its-mitesh-kumar

Labels

lgtm workspace/lightspeed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rohitratannagar @HusneShabbir @ShiranHi @its-mitesh-kumar